[patch 2/3] Add flags parameter to reserve_bootmem_generic()

Bernhard Walle bwalle at suse.de
Sun Jun 8 13:12:00 EDT 2008


* WANG Cong <xiyou.wangcong at gmail.com> [2008-06-08 22:26]:
>
> Since 'reserve_bootmem_generic' is changed from 'void' to 'int',
> we should check its return value for failure when possible, right?

That may make sense here, but that's unrelated to my change.

Just because the error *can* be caught by checking the return value
doesn't mean that it *must* be caught always. It was silently ignored
before in the efi_reserve_bootmem() function before, and so is it now.
No behaviour change.



Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Maintenance



More information about the kexec mailing list