[RFC][PATCH 1/3] Embed vmcoreinfo into kernel file

[Dan Aloni]

On Mon, Aug 13, 2007 at 04:36:53PM +0900, Ken'ichi Ohmichi wrote:
>[..]
> Patches:
> - [1/3] patch for linux-2.6.22.
>   Changelog:
>   * Rename "mkdfinfo" to "vmcoreinfo".
>   * Multi memory models (FLATMEM, DISCONTIGMEM, and SPASEMEM) are
>     supported.
>   * The elf note typedef for vmcoreinfo is added because the original
>     elf note size is limited to 1024.
>   * The generation of the elf note is moved to boot time instead of
>     crash time.

This looks very good. Just one suggestion - in order to reduce clutter 
from kernel/kexec.c (as to avoid #ifdefs) perhaps it might be better 
to have crash_save_vmcoreinfo_init() additionally call an arch-specific 
arch_crash_save_vmcoreinfo_init() function and have that append all 
the arch-specific stuff.

-- 
Dan Aloni
XIV LTD, http://www.xivstorage.com
da-x (at) monatomic.org, dan (at) xiv.co.il