[PATCH v2 1/7] AP: fix memory leaks in SAE offload error cases

Johannes Berg johannes at sipsolutions.net
Thu Mar 19 00:01:14 PDT 2026


On Thu, 2026-03-19 at 00:06 +0200, Jouni Malinen wrote:
> On Tue, Mar 17, 2026 at 05:35:49PM +0100, Johannes Berg wrote:
> > If SAE offload configuration fails in ieee802_11_build_ap_params(),
> > head/tail are leaked. Fix this by using an error label.
> 
> I applied the first four patches now as an initial step since they are
> not for UHR functionality.

Patch 4 was kind of irrelevant at that point, but sure :)

What should we plan for UHR?

My repost of this was actually requested by Qualcomm's AP team (I think,
I occasionally get mixed up who I'm talking to, sorry), but I don't know
what anyone's really planning to do.

As I said there also, I have no strong feelings about these patches - if
they end up dropped entirely because others have better ones, that's
perfectly fine too.

Another thing I could do is split out the refactoring parts, e.g. the
part that makes the station flags u64/ull.

johannes



More information about the Hostap mailing list