[PATCH v3 17/27] EPPKE: Add support for EPPKE authentication for SME-in-Userspace case

Benjamin Berg benjamin at sipsolutions.net
Fri Feb 13 00:23:28 PST 2026


Hi,

On Thu, 2026-01-15 at 22:02 +0530, Ainy Kumari wrote:
> [SNIP]
> diff --git a/wpa_supplicant/sme.c b/wpa_supplicant/sme.c
> index fba6508bc..3510faf74 100644
> --- a/wpa_supplicant/sme.c
> +++ b/wpa_supplicant/sme.c
> @@ -32,6 +32,9 @@
>  #include "scan.h"
>  #include "sme.h"
>  #include "hs20_supplicant.h"
> +#include "pasn/pasn_common.h"
> +#include "common/dragonfly.h"
> +#include "common/ptksa_cache.h"

I somehow had missed the warning earlier and maybe you already fixed
it. But during testing we noticed that this version of the patchset is
missing the crypto.h include.

> [SNIP]
> +	if (pasn->ecdh)
> +		crypto_ecdh_deinit(pasn->ecdh);
> +	pasn->ecdh = crypto_ecdh_init(group);

Due to this the return value is an integer, truncating the ECDH pointer
which can cause crashes.

Benjamin



More information about the Hostap mailing list