[PATCH] wpa_supplicant: s/MSG_INFO/MSG_DEBUG/ for messages starting "Successfully"

Jouni Malinen j at w1.fi
Sun Jan 26 12:33:33 PST 2025


On Thu, Jan 02, 2025 at 05:21:43PM +0000, Andrew Sayers wrote:
> Most messages of the form "Successfully..." are set to MSG_DEBUG.
> Standardising the outliers will make logs easier to read.

> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> @@ -3111,7 +3111,7 @@ static void wpa_supplicant_set_4addr_mode(struct wpa_supplicant *wpa_s)
>  		goto fail;
>  	}
>  	wpa_s->enabled_4addr_mode = 1;
> -	wpa_msg(wpa_s, MSG_INFO, "Successfully set 4addr mode");
> +	wpa_msg(wpa_s, MSG_DEBUG, "Successfully set 4addr mode");

Using wpa_msg() with MSG_DEBUG is not really ideal since the control
interface is at MSG_INFO verbosity by default and this would not be any
different from using wpa_printf(). wpa_dbg() would be more approriate
for this.

> diff --git a/wpa_supplicant/main.c b/wpa_supplicant/main.c
> @@ -346,7 +346,7 @@ int main(int argc, char *argv[])
> -		wpa_printf(MSG_INFO, "Successfully initialized "
> +		wpa_printf(MSG_DEBUG, "Successfully initialized "
>  			   "wpa_supplicant");

This is at MSG_INFO level by design to print out something and not just
leave a completely empty stdout output when starting wpa_supplicant with
a configuration that does not automatically start any specific visible
action.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list