[PATCH] Pass more capabilities of MLO link to framework
Jouni Malinen
j at w1.fi
Tue Dec 9 06:38:46 PST 2025
On Tue, Dec 02, 2025 at 03:09:38PM +0200, Jouni Malinen wrote:
> On Fri, Oct 03, 2025 at 07:44:55AM +0000, Bruno.Kremp at sony.com wrote:
> > Pass Channel Bandwidth and Maximum Number of Spatial Stream
> > of MLO link to framework, the information is necessary to
> > calculate the theoretical maximum speed for MLO link.
>
> This seems to be based on a modified hostap.git implementation since
> compilation with these changes would fail due to various missing
> functions and variables:
The previously missing commit in now in hostap.git, so I took a closer
look at the way this per-link variant is implemented.
It looks like ieee802_11_parse_link_assoc_resp() duplicates a
significant amount (i.e., most..) of functionality from the existing
ieee802_11_parse_link_assoc_req() function. This is not ideal and
instead, these two cases should be using a shared helper function to
avoid such code duplication.
The main difference between the existing functionality and the new one
seems to be in defragmentation of the Per-STA Profile information. The
new ieee802_11_defrag_per_sta_data() function would seem to duplicate
existing functionality in ieee802_11_defrag_mle_subelem(). That is not
really good way of doing this and instead, that existing hostap.git
functionality should be used which would be the case with that shared
helper function mentioned above.
Please also note that I cleaned up wpa_supplicant_event_associnfo() by
splitting the functionality related to determining connection
information into a separate helper function to avoid excessive
indentation and even longer function. In other words, the
wpa_supplicant/events.c changes would be in a bit different location in
the file.
--
Jouni Malinen PGP id EFC895FA
More information about the Hostap
mailing list