[PATCH] do not perform CSA on disabled BSS.

[Jouni Malinen]

On Sun, Jan 28, 2024 at 06:08:09PM +0100, Baligh Gasmi wrote:
> It is useless to perform a channel switch, by announcing the new channel
> information: CSA (Channel Switch Announcement), if the BSS is not running.

> diff --git a/hostapd/ctrl_iface.c b/hostapd/ctrl_iface.c
> @@ -2715,6 +2715,10 @@ static int hostapd_ctrl_iface_chan_switch(struct hostapd_iface *iface,
>  
>  	for (i = 0; i < iface->num_bss; i++) {
>  
> +		if(iface->bss[i]->disabled) {
> +			continue;
> +		}
> +
>  		/* Save CHAN_SWITCH VHT, HE, and EHT config */
>  		hostapd_chan_switch_config(iface->bss[i],
>  					   &settings.freq_params);

What would happen with the not yet started BSS in that case when it
might get enabled afterwards? Would it use the new channel from this
channel switch request? If not, this change might not be complete to
cover that case. It would seem most reasonable for all BSSs to be moved
to use the new channel and if there are disabled BSSs in this list, just
update their configuration immediately without going through CSA.
 
-- 
Jouni Malinen                                            PGP id EFC895FA