[PATCH] tests: gas_server_oom: leave time to process GAS request

Johannes Berg johannes at sipsolutions.net
Thu Jan 25 01:33:47 PST 2024


On Thu, 2024-01-25 at 10:29 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg at intel.com>
> 
> Due to scheduling in UML time-travel, the test may continue
> running and find that the failure didn't trigger when really
> the frame just didn't make it through to the other side. Add
> some time for the necessary processing.
> 
> Signed-off-by: Johannes Berg <johannes.berg at intel.com>
> ---
>  tests/hwsim/test_gas.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/hwsim/test_gas.py b/tests/hwsim/test_gas.py
> index d8b361e10323..0a35d63d1da1 100644
> --- a/tests/hwsim/test_gas.py
> +++ b/tests/hwsim/test_gas.py
> @@ -1918,6 +1918,9 @@ def test_gas_server_oom(dev, apdev):
>          if "OK" not in wpas.request(req):
>              raise Exception("Could not send management frame")
>          wait_fail_trigger(hapd, "GET_ALLOC_FAIL")
> +        # leave some time for the frame to be transmitted, received
> +        # and processed
> +        time.sleep(0.1)
> 

Umm. I'm an idiot - that wait_fail_trigger() is already another fix for
this, and I didn't realize it just now as I was rebasing my patch ... so
probably we should do the same in the FST test?

johannes



More information about the Hostap mailing list