[PATCH 38/42] tests: update ML discovery test to also check probe requests

Otcheretianski, Andrei andrei.otcheretianski at intel.com
Sun Nov 26 09:05:48 PST 2023


> > > Also check that we can discover BSSs requests using ML probe requests.
> > > Note that this requires a new enough mac80211 which parses the ML
> > > probe request and reports the contained BSSs.
> >
> > >  def test_eht_mld_discovery(dev, apdev):
> >
> > > +        # NOTE: hostap incorrectly reports a TSF offset of zero
> > > +        # This only works because the source is always the ML probe
> > response
> > > +        tsf1 = int(wpas.get_bss(hapd1.own_addr())['tsf'])
> >
> > Is that "hostap" supposed to be "hostapd"?
> 
> Yes.. Sorry.
> 
> >
> > This makes eht_mld_discovery fail for me since there is no BSS entry
> > for hapd1.. Does this need some kernel changes to alloc ML probe
> > request actually work or did something else end up breaking? I had to
> > fix a number of issues in earlier patches, so that might have an
> > impact. I cannot test the unmodified patches since they do not compile
> > and even after fixing the compilation issues (well, warnings), there
> > were issues that caused processes to terminate.
> >
> 
> I tested it with the latest wireless-next tree. I also didn't see any warnings
> (maybe I have a different gcc or something) - anyway, sorry about that.
> All the eht tests passed for me and should work.
> It indeed requires some kernel changes but everything should be there.
> I see most of the patchset is applied now, I will test it to see what happened
> there..
> 

I applied this on top of the latest main branch  + latest wireless-next kernel (arch=um) and the test passes. 

> 
> > --
> > Jouni Malinen                                            PGP id EFC895FA
> 
> _______________________________________________
> Hostap mailing list
> Hostap at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/hostap



More information about the Hostap mailing list