[PATCH] common: Fix ieee802_11_rsnx_capab()

Andrei Otcheretianski andrei.otcheretianski at intel.com
Thu Nov 2 06:21:52 PDT 2023


From: Daniel Gabay <daniel.gabay at intel.com>

The function should return bool (0/1) and not int.
In some environments bool may be defined as unsigned char, so bits
higher then 7 will be discarded during the downcast.
Fix it.

Signed-off-by: Daniel Gabay <daniel.gabay at intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski at intel.com>
---
 src/common/ieee802_11_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/common/ieee802_11_common.c b/src/common/ieee802_11_common.c
index 21c3ed7010..093339cb43 100644
--- a/src/common/ieee802_11_common.c
+++ b/src/common/ieee802_11_common.c
@@ -2962,7 +2962,7 @@ bool ieee802_11_rsnx_capab_len(const u8 *rsnxe, size_t rsnxe_len,
 	for (i = 0; i < flen; i++)
 		capabs |= rsnxe[i] << (8 * i);
 
-	return capabs & BIT(capab);
+	return !!(capabs & BIT(capab));
 }
 
 
-- 
2.38.1




More information about the Hostap mailing list