[PATCH] AP: Correctly set the BSS parameters change count in RNR

[Jouni Malinen]

On Thu, Dec 21, 2023 at 01:45:21PM +0200, Andrei Otcheretianski wrote:
> diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
> @@ -7599,7 +7599,8 @@ static u8 * hostapd_eid_rnr_iface(struct hostapd_data *hapd,
>  				else
>  					*eid++ = hapd->conf->mld_id;
>  
> -				*eid++ = hapd->mld_link_id | (1 << 4);
> +				*eid++ = hapd->mld_link_id |
> +					(hapd->eht_mld_bss_param_change << 4);
>  				*eid++ = 0;

That would not work correctly for values larger than 15. The BSS
Parameters Change Count field is in B12..B19, i.e., half of it is in the
third octet that would not be modified here.
 
-- 
Jouni Malinen                                            PGP id EFC895FA