[PATCH] hostapd: output ignore_broadcast_ssid when using STATUS

[Antonio Prcela]

Or would something like this be enough?
which I guess wouldn't as the '->conf' is passed to 'wpa_config_get_value()' and
not used within 'wpa_supplicant_ctrl_iface_get()'

diff --git a/hostapd/ctrl_iface.c b/hostapd/ctrl_iface.c
index f9a78651c..6542271e9 100644
--- a/hostapd/ctrl_iface.c
+++ b/hostapd/ctrl_iface.c
@@ -1367,6 +1367,11 @@ static int hostapd_ctrl_iface_get(struct hostapd_data *hapd, char *cmd,
                if (os_snprintf_error(buflen, res))
                        return -1;
                return res;
+       } else if (os_strcmp(cmd, "ignore_broadcast_ssid") == 0) {
+               res = os_snprintf(buf, buflen, "%d", hapd->conf->ignore_broadcast_ssid);
+               if (os_snprintf_error(buflen, res))
+                       return -1;
+               return res;
        }

        return -1;

On 20. 12. 2023. 12:15, Antonio Prcela wrote:
> Ok. Basically create a hostapd/config.c with 'hostapd_config_get_value()',
> like it is in wpa_supplicant/config.c with 'wpa_config_get_value()',
> to get all the available config paramters that are in hostapd.conf?
> 
> And call that new 'hostapd_config_get_value()' within 'hostapd_ctrl_iface_get()'?
> 
> Regards,
> Antonio
> 
> On 24. 11. 2023. 18:32, Jouni Malinen wrote:
>> On Tue, Nov 21, 2023 at 10:01:15AM +0100, Antonio Prcela wrote:
>>> Adding the ignore_broadcast_ssid config parameter to the STATUS output to determine
>>> the current ignore_broadcast_ssid config of an hostapd access-point.
>>> Currently neither STATUS, GET ignore_broadcast_ssid, nor GET_CONFIG output it.
>>>
>>> Useful if the hostapd access point has been created with wpa_ctrl_request()
>>> without using a *.conf file, for example hostapd.conf.
>>
>> I'm not sure I really understand the use case here, but regardless, this
>> should not be added to STATUS. If there is some reasonable use cases
>> where external components need to look at the values they have set
>> themselves (sounds a bit strange..) or some other external component has
>> set (a bit more reasonable use case, I guess), the GET command would be
>> the one to extend.
>>