[PATCH 1/2] wpa_supplicant: src: Remove the word "whitelist"

Johannes Berg johannes at sipsolutions.net
Wed Jan 12 00:12:29 PST 2022


On Tue, 2022-01-11 at 16:06 -0800, Arowa Suliman wrote:
> First of all, thanks for the review, I submitted a v2 patch list for
> the comments changes. However, for the enum values how can we get
> acknowledgement from existing users of the interface? should I submit
> another patch list for these changes and keep it under review to get
> other users feedback?

This won't address your "code base must be free of these words" needs,
but the right way to rename enums would seem to be to offer a #define
for the old name, e.g.

-	QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS = 3,
+	QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_NUM_NETWORKS = 3,

...

+/* old names for API compatibility */
+#define QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_WHITE_LIST_SSID_NUM_NETWORKS QCA_WLAN_VENDOR_ATTR_ROAMING_PARAM_ALLOW_LIST_SSID_NUM_NETWORKS
...

johannes



More information about the Hostap mailing list