[PATCH v2 08/14] AP: Move anti clogging handling code

Peer, Ilan ilan.peer at intel.com
Tue Jan 26 02:05:07 EST 2021


> -----Original Message-----
> From: Jouni Malinen <j at w1.fi>
> Sent: Tuesday, January 26, 2021 00:58
> To: Peer, Ilan <ilan.peer at intel.com>
> Cc: hostap at lists.infradead.org
> Subject: Re: [PATCH v2 08/14] AP: Move anti clogging handling code
> On Wed, Dec 16, 2020 at 01:00:59PM +0200, Ilan Peer wrote:
> > The anti-clogging code was under CONFIG_SAE. Move it around so it can
> > be used both with CONFIG_SAE and CONFIG_PSAN.
> >  src/ap/ieee802_11.c | 308
> > +++++++++++++++++++++++---------------------
> >  1 file changed, 158 insertions(+), 150 deletions(-)
> This is undesired way of handling such changes since it makes the patch
> difficult to review and introduces undesired whitespace changes. I'll replace
> this with the actual needed changes which are minimal. Moving functions
> around can be done separately if such cleanup is ever needed, but it should
> no be in the middle of a patch series since it can so easily cause conflicts with
> any following change in this area.

I think I did not do any functional changes other than moving the code and changing
some ifdefs, but I understand the headache this would cause while reviewing and
applying the changes. Will take this into consideration in the future.



More information about the Hostap mailing list