[PATCH v2 07/14] AP: Rename SAE anti clogging variables and functions

Peer, Ilan ilan.peer at intel.com
Tue Jan 26 02:01:26 EST 2021


Hi,

> -----Original Message-----
> From: Jouni Malinen <j at w1.fi>
> Sent: Tuesday, January 26, 2021 00:56
> To: Peer, Ilan <ilan.peer at intel.com>
> Cc: hostap at lists.infradead.org
> Subject: Re: [PATCH v2 07/14] AP: Rename SAE anti clogging variables and
> functions
> 
> On Wed, Dec 16, 2020 at 01:00:58PM +0200, Ilan Peer wrote:
> > PASN authentication mandates support for comeback flow, which among
> > others can be used for anti-clogging purposes.
> >
> > As the SAE support for anti clogging can also be used for PASN, start
> > modifying the source code so the anti clogging support can be used for
> > both SAE and PASN.
> >
> > As a start, rename some variables/functions etc. so that they would
> > not be SAE specific.
> 
> > diff --git a/hostapd/config_file.c b/hostapd/config_file.c @@ -4203,8
> > +4203,8 @@ static int hostapd_config_fill(struct hostapd_config *conf,
> 
> > -	} else if (os_strcmp(buf, "sae_anti_clogging_threshold") == 0) {
> > -		bss->sae_anti_clogging_threshold = atoi(pos);
> > +	} else if (os_strcmp(buf, "anti_clogging_threshold") == 0) {
> > +		bss->anti_clogging_threshold = atoi(pos);
> 
> This does not look reasonable since it would break backwards compatibility
> with existing hostapd SAE configuration and would prevent updated hostapd
> from starting with previously working configuration.
> Furthermore, this does not update hostapd/hostapd.conf to match. I'll drop
> this part about renaming the configuration variable itself.
> 

Agree. I did not properly take this into consideration.

> > diff --git a/tests/hwsim/test_sae.py b/tests/hwsim/test_sae.py @@
> > -256,7 +256,7 @@ def test_sae_anti_clogging(dev, apdev):
> > -    params['sae_anti_clogging_threshold'] = '1'
> > +    params['anti_clogging_threshold'] = '1'
> 
> I'll drop these changes to test_sae.py since they should not be needed with
> backwards compatible manner of handling configuration parameter names.
> 

Sure.

So eventually this patch would end up by only renaming internal functions and
variables? Are you introducing another configuration option to also set the
PASN anti clogging?

Regards,

Ilan.  
 



More information about the Hostap mailing list