[PATCH] build: fix dependency file inclusion

Johannes Berg johannes at sipsolutions.net
Sun Oct 11 15:24:34 EDT 2020

From: Johannes Berg <johannes.berg at intel.com>

The objs.mk include changes for archive files broke things
completely and none of the dependency files (*.d) ever got
included, as the expansion there ended up empty.

Clearly, my mistake, I should've tested that better. As we
don't need the %.a files in the list there use filter-out
to remove them, rather than what I had lazily wanted to do,
which was trying to read %.d files for them. The filter-out
actually works, and avoids looking up files that can never
exist in the first place.

Fixes: 87098d3324e0 ("build: Put archive files into build/ folder too")
Signed-off-by: Johannes Berg <johannes.berg at intel.com>
 src/objs.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/objs.mk b/src/objs.mk
index 54e42e6999df..a3040b21bd94 100644
--- a/src/objs.mk
+++ b/src/objs.mk
@@ -1,3 +1,3 @@
 $(_OBJS_VAR) := $(call BUILDOBJ,$($(_OBJS_VAR)))
--include $($($(_OBJS_VAR):%.o=%.d):%.a=%.d)
+-include $(filter-out %.a,$($(_OBJS_VAR):%.o=%.d))
 _DIRS += $(dir $($(_OBJS_VAR)))

More information about the Hostap mailing list