[PATCH] wpa_supplicant: Should disconnect on deinit whatever WOWLAN is enable or disable

xing wan 18071720608 at 163.com
Sat Nov 7 05:32:07 EST 2020


Dear Hostap organization
--------------------------------------------------------
[wpa_supplicant] Rollback change list:02c21c02d09fdce55c0048cc58ff870cab77c9e9

[Description]

  The function wpa_drv_get_wowlan() is to get signal of whether wowlan is triggered by wpa itself to kernel through wpa_drv_wowlan() function. Trigger action depends on the flag<wowlan_triggers = xx> in wpa_supp.conf. 

  It must need to disconnect on interface deinit whatever WOWLAN is enable or disable, because deinit means that interface is removed or wpa_supplicant process killed.
  If don't do so, the status between kernel/wifi driver and wpa_supplicant will be different and it will occur wifi unexpected behavior.
       E.g: 
            when supplicant re-started up, the status of supplicant is disconnected while kernel and wifi driver is connected because  wifi don't accept any disconnected or deauth signal before.
            And then, it could't scan any aps with <NL_SCAN_FLAGE_RANDOM_ADDR> scan cmd since kernel thinks wifi is already connected and block this scan flag.

Signed-off-by: xing wan <18071720608 at 163.com>

--------------------------------------------------------
diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
index ea62e59..384b10a 100644
--- a/wpa_supplicant/wpa_supplicant.c
+++ b/wpa_supplicant/wpa_supplicant.c
@@ -6318,17 +6318,11 @@
 
 	wpa_s->disconnected = 1;
 	if (wpa_s->drv_priv) {
-		/* Don't deauthenticate if WoWLAN is enabled */
-		if (!wpa_drv_get_wowlan(wpa_s)) {
-			wpa_supplicant_deauthenticate(
-				wpa_s, WLAN_REASON_DEAUTH_LEAVING);
+		wpa_supplicant_deauthenticate(wpa_s,
+						WLAN_REASON_DEAUTH_LEAVING);
 
-			wpa_drv_set_countermeasures(wpa_s, 0);
-			wpa_clear_keys(wpa_s, NULL);
-		} else {
-			wpa_msg(wpa_s, MSG_INFO,
-				"Do not deauthenticate as part of interface deinit since WoWLAN is enabled");
-		}
+		wpa_drv_set_countermeasures(wpa_s, 0);
+		wpa_clear_keys(wpa_s, NULL);
 	}
 
 	wpa_supplicant_cleanup(wpa_s);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: wpa_supplicant.diff
Type: application/octet-stream
Size: 823 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/hostap/attachments/20201107/314d3860/attachment.obj>


More information about the Hostap mailing list