[PATCH 1/2] wpa_cli: Fix duplicate const warning

Masashi Honma masashi.honma at gmail.com
Sat Feb 3 17:49:14 PST 2018

On 2018/02/03 19:19, Jouni Malinen wrote:
> That's wrong..
>> diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c
>> -static const char const *cred_fields[] = {
>> +static const char *cred_fields[] = {
> But this is not the fix.. I'd assume this was supposed to be an array of
> const-pointer to const-char, so I'll replace this with 'const char *
> const' instead.

The cred_fields looks be used by only one function. So how about making it local
variable and using the name "fields" ? Just like wpa_cli_complete_get_capability().

Masashi Honma.

More information about the Hostap mailing list