[PATCH 4] Change the default value of wmm_enabled to 0 as WMM is now required to be explicitly enabled with HT/VHT/HE.

Jouni Malinen j at w1.fi
Sat Feb 25 09:29:25 PST 2017


On Sat, Feb 25, 2017 at 03:15:39PM +0000, Nick Lowe wrote:
> Change the default value of wmm_enabled to 0 as WMM is now required to
> be explicitly enabled with HT/VHT/HE.

> - /* Set to -1 as defaults depends on HT in setup */
> - bss->wmm_enabled = -1;
> + bss->wmm_enabled = 0;

It would be simpler to just delete this line completely rather than add
clearing of memory that is anyway initiated to zero.. Anyway, this in
combination with the earlier patch checking that wmm_enabled is set for
HT/VHT/HE would break large number of existing configurations. I'm not
going to apply this. The current behavior seems fine to me; no need to
force everyone change their configuration to add wmm_enabled=1
explicitly.
 
-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list