Possible bug in throughput based roaming

[Jouni Malinen]

On Mon, Jan 16, 2017 at 08:30:14PM +0100, Andreas Pasternak MT-Robot AG wrote:
> In http://w1.fi/cgit/hostap/tree/wpa_supplicant/events.c
> 
> if (current_bss->est_throughput > selected->est_throughput + 5000) {
> wpa_dbg(wpa_s, MSG_DEBUG,
> "Skip roam - Current BSS has better estimated throughput");
> 
> // !!!!
> return 1;  // !!! Should this not be return 0; !!! ???
> // !!!!
> }
> 
> As far as I understood this function returns 1 if roaming should occur and 0

Yes, indeed. It looks like this could be a copy-paste error in a commit
that added this new skip-roam case. I'll fix it to return 0.

-- 
Jouni Malinen                                            PGP id EFC895FA