[PATCH v2 04/33] FT: add support for wildcard R0KH / R1KH

[Jouni Malinen]

On Sat, Sep 24, 2016 at 10:53:45PM +0200, Michael Braun wrote:
> This enables using FT RRB without configuring each other AP locally.
> Instead, broadcast messages are exchanged.

> diff --git a/src/ap/wpa_auth.h b/src/ap/wpa_auth.h
> @@ -44,6 +44,7 @@ struct ft_rrb_frame {
>  #define FT_R0KH_R1KH_PULL_DATA_LEN (FT_R0KH_R1KH_PULL_NONCE_LEN + \
> +				    FT_R0KH_ID_MAX_LEN + 1 + \
>  				    WPA_PMK_NAME_LEN + FT_R1KH_ID_LEN + \
>  				    ETH_ALEN)

> @@ -55,6 +56,8 @@ struct ft_r0kh_r1kh_pull_frame {
>  	u8 nonce[FT_R0KH_R1KH_PULL_NONCE_LEN];
> +	u8 r0kh_id[FT_R0KH_ID_MAX_LEN];
> +	u8 r0kh_id_len;
>  	u8 pmk_r0_name[WPA_PMK_NAME_LEN];

Wouldn't these changes break backwards compatibility with existing
implementation by modifying the pull message format? I don't think this
should be done more than once, i.e., this types of extensions should be
done only after there is a new message format (e.g., if patch 9/33 were
to be applied first). Furthermore, the commit message should be very
clear about breaking backwards compatibility (here and in 9/33 for that
matter).

-- 
Jouni Malinen                                            PGP id EFC895FA