[PATCH 8/8] mka: add driver op to get macsec capabilities

[Jouni Malinen]

On Tue, Sep 20, 2016 at 09:43:11AM +0200, Sabrina Dubroca wrote:

>  src/drivers/driver.h          |  2 ++
>  src/pae/ieee802_1x_kay.c      | 15 +++++++++++++--
>  src/pae/ieee802_1x_kay.h      |  1 +
>  src/pae/ieee802_1x_secy_ops.c | 20 ++++++++++++++++++++
>  src/pae/ieee802_1x_secy_ops.h |  1 +
>  wpa_supplicant/driver_i.h     |  9 +++++++++
>  wpa_supplicant/wpas_kay.c     |  7 +++++++
>  7 files changed, 53 insertions(+), 2 deletions(-)

So no changes to src/drivers/driver_macsec_qca.c?

>  	 * enable_protect_frames - Set protect frames status
>  	 * @priv: Private driver interface data
> diff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c
> @@ -3412,6 +3417,12 @@ ieee802_1x_kay_change_cipher_suite(struct ieee802_1x_kay *kay,
>  	kay->macsec_csindex = cs_index;
>  	kay->macsec_capable = cipher_suite_tbl[kay->macsec_csindex].capable;
>  
> +	if (secy_get_capability(kay, &secy_cap) < 0)
> +		return -3;

Wouldn't this call to secy_get_capability() return -1 for unmodified
driver_macsec_qca.c and as such, this patch would break that driver
wrapper?

-- 
Jouni Malinen                                            PGP id EFC895FA