[PATCH] command to disable eapol ip functionality from both Go and client side
j at w1.fi
Thu Mar 17 12:31:28 PDT 2016
On Tue, Mar 15, 2016 at 03:09:33AM +0000, Avichal Agarwal wrote:
> If we enable and disable the group capability field through a user flag then it will be more feasible and easy for the user
> to control the eapol ip functionality from go side. In last patch I left two files changes , so sending the full patch again.
I'm still not sure I understand why this new parameter would be needed.
How does this make it any easier than doing "SET ip_addr_start 0.0.0.0"
to disable the functionality?
That said, the new files you added in this version does identify an
issue in p2p_group.c:
> diff --git a/src/p2p/p2p_group.c b/src/p2p/p2p_group.c
> @@ -155,7 +155,8 @@ static void p2p_group_add_common_ies(struct p2p_group *group,
> - group_capab |= P2P_GROUP_CAPAB_IP_ADDR_ALLOCATION;
> + if(!(group->p2p->disable_eapolip))
> + group_capab |= P2P_GROUP_CAPAB_IP_ADDR_ALLOCATION;
> p2p_buf_add_capability(ie, dev_capab, group_capab);
That setting should have already been conditional on ip_addr_start being
set to a non-zero value because that's the condition the authenticator
uses to determine whether to assign an IP address during 4-way
Jouni Malinen PGP id EFC895FA
More information about the Hostap