[PATCH v5 17/25] wpaspy: add debug support for Ctrl UDP class
j at w1.fi
Mon Mar 7 00:58:38 PST 2016
On Sun, Mar 06, 2016 at 12:01:07PM +0100, Janusz Dziedzic wrote:
> On 5 March 2016 at 15:50, Jouni Malinen <j at w1.fi> wrote:
> > On Fri, Mar 04, 2016 at 10:20:33AM +0100, Janusz Dziedzic wrote:
> >> Add debug support for Ctrl class. This is
> >> useful for debuging purpose for UDP connection.
> > While this may be useful for some debugging purposes, this would also
> > unconditionally add logger.debug() calls for private information that
> > may include passwords. I don't think this is appropriate since wpaspy.py
> > can be used outside testing environment.
> Yes, but added only for UDP path. While UDP CTRL (no encryption)
> should be used only for test purpose, will that be a problem?
One could claim so, but I'm not sure I really see the point of wpaspy
having these debug prints with the contents of the messages for one of
the mechanisms. Those debug prints are already in place in run-tests.py
Jouni Malinen PGP id EFC895FA
More information about the Hostap