compile error buglet

Jouni Malinen j at w1.fi
Sun Feb 21 23:57:43 PST 2016


On Mon, Feb 22, 2016 at 12:26:56AM +0000, Danny Thomas wrote:
> My initial build of eapol_test did not define CONFIG_IEEE8021X_EAPOL
> and resulted in the these errors.

What were going to use eapol_test for? CONFIG_IEEE8021X_EAPOL is enabled
if any of the EAP methods is included in the build and eapol_test is not
really of any use without that..

> eapol_test.c:637:32: error: no member named 'eap_workaround' in
>       'struct wpa_ssid'
>         eapol_conf.workaround = ssid->eap_workaround;
>                                 ~~~~  ^
> eapol_test.c:639:46: error: no member named 'eap' in 'struct wpa_ssid'
>         eapol_sm_notify_config(wpa_s->eapol, &ssid->eap, &eapol_conf);
> 
> 
> The errors went away after I wrapped each of these lines within
>     #ifdef IEEE8021X_EAPOL
>     #endif /* IEEE8021X_EAPOL */
> to match the structure definition in config_ssid.h.

I don't see any real value from such complexity taken into account that
eapol_test is not going to work without IEEE8021X_EAPOL.

> Defining CONFIG_IEEE8021X_EAPOL=y also resulted in a successful compile.

And this is the way to fix the issue to make an actually working binary.
Though, that is already set automatically when enabling the EAP methods
for the build which would be the normal way of configuring build for
eapol_test.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list