[PATCH 0/6] mka cleanups

Sabrina Dubroca sd at queasysnail.net
Mon Aug 29 06:03:05 PDT 2016

Hi Jouni,

2016-08-28, 22:40:35 +0300, Jouni Malinen wrote:
> On Mon, Aug 15, 2016 at 11:40:37AM +0200, Sabrina Dubroca wrote:
> > This patchset contains a variety of cleanups for the MKA code (src/pae).
> > Sabrina Dubroca (6):
> >   mka: some cleanups
> >   mka: cleanups, part 2
> >   mka: cleanups, part 3
> >   mka: cleanups, part 4
> >   mka: move structs {transmit,receive}_{sa,sc} to a common header
> >   mka: pass full structures down the stack in ops callbacks
> Thanks, I applied patches 1..4, but left patches 5 and 6 waiting for
> updates as noted in the earlier messages.

Thanks, I'll update and resend these two.

> Please note that I split the
> patches in significantly smaller independent changes (total of 29
> patches instead of just 4) to make it easier to review them. I did some
> cleanup and fixes, e.g., sci_equal() was using sizeof(a) where a is a
> pointer while this was supposed to use the size of the data structure;
> it happened to be 8 so no difference on 64-bit builds, but for 32-bit
> builds, this could have resulted in incorrect behavior. Please check
> that I did not end up breaking any functionality with the changes.

I reviewed the diff between my local branch and your tree, and it
looks okay.  I'll run some tests before I submit more patches and send
fixes if necessary.

> For any followup cleanup, please consider making smaller patches. That
> would make it significantly easier to review the changes by finding the
> obvious changes without having to figure out which parts of the patch
> apply to which item in the commit message (and which parts are missing
> altogether from the commit message).

Okay, sorry about that.  I have a few other rather big patches coming
up, I'll try to split them up.

> I left out one change since I did not find any justification in the
> commit message for it and did not see it as an obvious improvement
> myself. Please resubmit this with more descriptive commit message if you
> still want this included:
> [PATCH] mka: Move kay_ops struct out of ieee802_1x_alloc_kay_sm()

I prefer this style, but it doesn't make a huge difference.  Since you
prefer the current version, I'll just drop this change.



More information about the Hostap mailing list