[PATCH 5/6] mka: move structs {transmit, receive}_{sa, sc} to a common header

Jouni Malinen j at w1.fi
Mon Aug 22 11:12:42 PDT 2016

On Mon, Aug 15, 2016 at 11:43:43AM +0200, Sabrina Dubroca wrote:
> Signed-off-by: Sabrina Dubroca <sd at queasysnail.net>

Could you please provide a bit more detailed commit message describing
why this would be done?

>  src/common/ieee802_1x_defs.h  | 69 +++++++++++++++++++++++++++++++++++++++++++

I'm not sure src/common/*.h is an appropriate location for this type of
definitions. I'd expect this file to include frame definitions and that
type of common defines/structures while the structs added here look more
like implementation specific data. What would those be shared with
(outside src/pae) and what is the "common" part here?

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list