[PATCH] driver_nl80211: fix control port protocol no-encrypt setting

Jouni Malinen j at w1.fi
Thu Aug 18 12:48:22 PDT 2016

On Wed, Aug 17, 2016 at 11:40:25AM +0200, Johannes Berg wrote:
> Currently, driver_nl80211 sets NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT
> in AP mode, to get 802.1X frames out unencrypted. However, due to
> the way nl80211/cfg80211 is implemented, this attribute is ignored
> by the kernel if NL80211_ATTR_CONTROL_PORT_ETHERTYPE isn't specified
> as well. Fix this by including NL80211_ATTR_CONTROL_PORT_ETHERTYPE
> set to ETH_P_PAE. This can be done unconditionally, since the kernel
> will allow ETH_P_PAE to be set even when the driver didn't advertise
> support for arbitrary ethertypes.
> Additionally, the params->pairwise_ciphers appear to not be set at
> this point, so relax the check and allow them to be zero.
> In client mode, this whole thing was missing, so add it. Again, the
> pairwise suite can be WPA_CIPHER_NONE, so allow that case as well.

Thanks, applied.
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list