[PATCH] radius: sanity check for null pointer segfault

Eduardo Abinader eduardoabinader at gmail.com
Wed Aug 17 10:29:39 PDT 2016


When no radius is configured, mib command is segfaulting
hostapd.

Signed-off-by: Eduardo Abinader <eduardoabinader at gmail.com>
---
 src/radius/radius_client.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/radius/radius_client.c b/src/radius/radius_client.c
index a4edd5f..f7fef5b 100644
--- a/src/radius/radius_client.c
+++ b/src/radius/radius_client.c
@@ -1636,11 +1636,16 @@ static int radius_client_dump_acct_server(char *buf, size_t buflen,
 int radius_client_get_mib(struct radius_client_data *radius, char *buf,
 			  size_t buflen)
 {
-	struct hostapd_radius_servers *conf = radius->conf;
+	struct hostapd_radius_servers *conf;
 	int i;
 	struct hostapd_radius_server *serv;
 	int count = 0;
 
+	if (!radius)
+		return -1;
+
+	conf = radius->conf;
+
 	if (conf->auth_servers) {
 		for (i = 0; i < conf->num_auth_servers; i++) {
 			serv = &conf->auth_servers[i];
-- 
2.5.0




More information about the Hostap mailing list