[PATCH 13/14] ctrl: Enable adding profiles for P2P device interface

[Peer, Ilan]

> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Friday, October 16, 2015 20:50
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com; Stern, Avraham
> Subject: Re: [PATCH 13/14] ctrl: Enable adding profiles for P2P device
> interface
> 
> On Wed, Oct 14, 2015 at 06:43:19PM +0300, Ilan Peer wrote:
> > Redirect the commands ADD_NETWORK and SET_NETWORK from the global
> > control interface to the P2P Device interface to enable adding netwrok
> > profiles to the P2P Device interface.
> >
> > This can be used to add persistent groups that will be used later by
> > the P2P Device to re-invoke the persistent group.
> >
> > These commands are enabled on the global control interface only when
> > TESTING_OPTIONS is configured.
> 
> Could you please explain why these are conditional on
> CONFIG_TESTING_OPTIONS? Either these should be supported on the global
> interface in all cases or they should not be used at all. I don't see what would
> be the justification for having a special testing only code path for this.
> 

These were under CONFIG_TESTING_OPTIONS since we were not aware of any real use case for this other than hwsim testing. They can be supported on global control interface without limitation AFAIC.

Thanks,

Ilan.