[PATCH 05/14] tests: Change persistent_group_missed_inv_resp() test

Peer, Ilan ilan.peer at intel.com
Thu Oct 22 07:09:44 PDT 2015


> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Friday, October 16, 2015 20:30
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com; Stern, Avraham
> Subject: Re: [PATCH 05/14] tests: Change
> persistent_group_missed_inv_resp() test
> 
> On Wed, Oct 14, 2015 at 06:43:11PM +0300, Ilan Peer wrote:
> > Support configurations that use a dedicated P2P device interface by
> > setting ext_mgmt_frame_handling and waiting for MGMT-RX event on the
> > global control interface.
> 
> This sounds pretty confusing.. How could MGMT-RX be a global event? It is
> very much bound to a specific interface just like the
> ext_mgmt_frame_handling parameter. This does not look like a good way of
> addressing the issue.
> 

Would you prefer to handle this by adding an argument to the mgmt._rx to state if this is P2P frame or not and have the method resolve the interface name internally based on whether P2P Device is used or not (something similar to list_networks()).

Thanks,

Ilan.




More information about the Hostap mailing list