[PATCH 08/12] hs20-client: specify spp.xsd, pass ca-fname to curl

Jouni Malinen j
Sat Mar 28 04:03:10 PDT 2015


On Thu, Mar 26, 2015 at 05:39:54PM -0400, greearb at candelatech.com wrote:
> Allow user to specify the path to the spp.xsd file.
> 
> Use configured 'osu-ca.pem' file if user has specified one.
> If not, then use the default osu-ca.pem when calling libcurl.
> 
> Add some debugging messages as well.

Could you please split this into three parts and remove unrelated
changes like these:

> @@ -1,4 +1,4 @@
> -/*
> +/* -*-linux-c-*-

> @@ -960,6 +961,7 @@ int cmd_prov(struct hs20_osu_client *ctx, const char *url)
>  	if (soap_init_client(ctx->http, url, ctx->ca_fname, NULL, NULL, NULL,
>  			     NULL) < 0)
>  		return -1;
> +
>  	spp_post_dev_data(ctx, SPP_SUBSCRIPTION_REGISTRATION,
>  			  "Subscription registration", NULL, NULL);




> +		wpa_printf(MSG_DEBUG, "Calling cmd-prov from main\n");

No "\n" at the end of wpa_printf() strings. They get added
automatically.
 
-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list