[PATCH 03/16] P2P: Clear BSS list when clearing the P2P state

Peer, Ilan ilan.peer
Tue Jun 30 03:50:53 PDT 2015



> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Monday, June 29, 2015 20:26
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com
> Subject: Re: [PATCH 03/16] P2P: Clear BSS list when clearing the P2P state
> 
> On Sun, Jun 21, 2015 at 01:24:53PM +0000, Peer, Ilan wrote:
> > > From: Jouni Malinen [mailto:j at w1.fi] Why would this be done? If an
> > > upper layer applications wants to clear the BSS list, it can do so
> > > (e.g., "BSS_FLUSH 0"). I don't see why P2P_FLUSH should explicitly
> > > force this to happen.
> >
> > This was added since at least for the case of a dedicated P2P Device
> interface the command to flush a BSS does not exist. Would you consider
> adding this to the P2P global interface redirection. Alternatively, this can be
> added conditionally only for the case of a dedicate P2P Device interface.
> 
> Hmm.. What do you mean with the command not existing? "BSS_FLUSH 0" can
> be issued to any wpa_supplicant interface.
> 

I might be missing something here ... as far as I understood the P2P Device management interface should not be visible to the higher layers, and it should not be accessed directly. In case that a dedicated P2P Device interface is used there is no way to flush the BSS table other than accessing it directly (this is required in some of the hwsim tests).

> What command are you proposing to redirect here?
> 

BSS_FLUSH. 

> I just don't see why P2P_FLUSH would clear BSS table. P2P state and BSS table
> are two completely independent data structures.
> 

Some of the P2P  Device flows rely on the data that is in the BSS table, and as such I thought that clearing it as part of the P2P flush flow made sense. Regardless, at least for the hwsim tests, we need a way to flush the BSS table when a P2P Device interface is used.

Thanks in advance,

Ilan.



More information about the Hostap mailing list