[EDT] [PATCH] tests: Validate .config file for wpa_supplicant build

Jouni Malinen j
Sun Jun 14 02:11:10 PDT 2015

On Fri, Jun 12, 2015 at 05:17:52AM +0000, Amit Khatri wrote:
> I have modified the script according to sh shell. Now it will work on both shells.

It does not look like this validation is that thorough.. The only thing
it notices is if one of the three config options is in the file, but
commented out with '#'. It does not say anything if the line is missing

To be honest, I'm not completely sure what's the point of this build.sh
change. It is possible to build wpa_supplicant through other mechanisms
that running build.sh. This type of warnings would make more sense if
indicated as a reason for a test failure (or better yet, cleanly skip
test cases that are not supported by the configuration). It could also
make sense to provide more details if wpa_supplicant fails to start for
a test case.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list