[PATCH] P2P : Add Operating class 125 for P2P supported channels

Jouni Malinen j
Fri Apr 3 01:06:39 PDT 2015


On Thu, Apr 02, 2015 at 04:37:35PM +0000, Ben Abdessalem, AmrX wrote:
> Could you please consider the attached patch for merging ?
> It's about adding operating class 125 for P2P supported channels list.

Could you please clarify why this should be allowed for P2P use cases?
Class 124 covers the channels 149-161 that have been defined with the
NomadicBehavior behavior limits set while Class 125 channels
149-165(169) have LicenseExemptBehavior behavior limits set that
is for "some fixed stations [that] can be operated without a license at
a higher radiated transmit power than permitted for nomadic use". For
me, that reads as something that is not really suitable for P2P.

> diff --git a/src/common/ieee802_11_common.c b/src/common/ieee802_11_common.c
> @@ -612,6 +612,10 @@ static int ieee80211_chan_to_freq_us(u8 op_class, u8 chan)
> +	case 5: /* channels 149,153,157,169 */
> +		if (chan < 149 || chan > 169)
> +			return -1;
> +		return 5000 + 5 * chan;
> @@ -764,12 +768,15 @@ static int ieee80211_chan_to_freq_global(u8 op_class, u8 chan)
> +	case 125: /* channels 149,153,157,161,165,169 */
> +		if (chan < 149 || chan > 169)
> +			return -1;
> +		return 5000 + 5 * chan;

I'm fine with these in the generic (not specific to P2P) helper
functions, but rest of the changes are P2P specific and need clearer
justification on the applicability of LicenseExemptBehavior for P2P use
cases.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list