[PATCH v2 00/20] mesh support for wpa_supplicant

Jouni Malinen j
Sun Oct 5 12:47:48 PDT 2014

On Sun, Sep 28, 2014 at 09:45:12PM +0300, Jouni Malinen wrote:
> I pushed my temporary work branch ('mesh') into hostap.git to make it
> easier to see where I'm with the review and to send any additional
> patches on top of that version, if needed.

I went through the initial review round and did some coding style
cleanup and commit splitting to make this easier. I also ran the changes
through couple of static analyzers and fixed the outcome (some
allocations were no checked, etc., small things).

There were couple of violations of expected interface design in src/ap/*
calling directly to wpa_supplicant/* which is not allowed. Similarly,
wpa_supplicant/* cannot include src/ap/*_i.h (internal header files).
Both of those were straightforward to fix, so those changes are in as

I pushed the current snapshot after all my changes into the mesh branch
in hostap.git.

I still need to review the details of SAE changes since those can affect
non-mesh cases. In addition, it would be nice to get somewhat more
description commit messages for couple of the commits, like these:

    nl80211: Process mesh point interface like station interface
    nl80211: Do not reset mesh point interface type on deinit
    nl80211: Reject deauth/disassoc for mesh interface
    nl80211: Do not set zero STA capability (mesh)
    nl80211: Do not try to change supported rates
    nl80211: set_key updates for mesh
    nl80211: Add WPA_IF_MESH (TODO: why?)
    write SAE key_mgmt to config

Most of these are from the commits that I needed to split into smaller
pieces to be able to review the changes. I could not understand why some
of these were done, so that explanation should be added to those
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list