[PATCH 02/12] mesh: Cancel previous dot11MeshConfirmTimeout before registering

Bob Copeland me
Tue Nov 4 05:49:29 PST 2014

On Tue, Nov 04, 2014 at 02:36:43PM +0900, Masashi Honma wrote:
> Signed-off-by: Kazuyuki Sakoda <KazuyukiA.Sakoda at jp.sony.com>
> Signed-off-by: Masashi Honma <masashi.honma at gmail.com>

> @@ -676,6 +679,8 @@ static void mesh_mpm_fsm(struct wpa_supplicant *wpa_s, struct sta_info *sta,
>  			break;
>  		case CNF_ACPT:
>  			wpa_mesh_set_plink_state(wpa_s, sta, PLINK_CNF_RCVD);
> +			eloop_cancel_timeout_one(plink_timer, wpa_s, sta,
> +						 &remaining);
>  			eloop_register_timeout(dot11MeshConfirmTimeout, 0,
>  					       plink_timer, wpa_s, sta);
>  			break;

I believe we already cancel it in the right places (popen, close, estab,
and teardown), but do let me know if I missed a case.  It should be
easy to tell if so by setting large timeouts and checking if any of these
new eloop_cancel_timeout_one() calls return non-zero.

Bob Copeland %% www.bobcopeland.com

More information about the Hostap mailing list