[PATCH 0/9] wpa_supplicant P2P DBus API improvements

Tomasz Bursztyka tomasz.bursztyka
Wed May 14 06:10:37 PDT 2014


Here is a serie of patches targetting wpa_supplicant's DBus API.
The 4 first ones are basic fixes on the API internal specification.

The 5 next ones are solving 1 big issue: once we pair with another peer,
there is no proper way to find out to which group this peer now ends up

There was some attempt to solve this via the GroupMember object, used in
Members property of a group. But - when this was used only when the group
is the GO - the GroupMember object still could not help to make any
relationship with the originated Peer object since it provides no properties
or methods. Not to say it was then useless in case the group is just the client.

Finally, I ended up removing this GroupMember since the Peer owns all the
informations we need with 2 new properties: IntendedAddress and Group,
which are only set once paired, obviously. A relevant PropertiesChanged()
signal is now thrown from a Peer object when required.

Group property of a Peer, give the group object path it belongs to, no
matter the role of the group object is.

Members of a group is still there, serving its role as before (on GO),
but instead of GroupMember, it provides a list of peer object path.

Please review, 

Tomasz Bursztyka (9):
  dbus: Declare GONegociation signals properly
  dbus: Fix interface DeviceFound signal specification
  dbus: Provide the p2p device address from the relevant structure
  dbus: No need to recompute group object path on GroupStarted signal
  dbus: Provide the intended address of the peer
  wpas: Add p2p utility function to get go iface from a peer dev address
  dbus: Add a Group property to Peer object which will hold its group
  dbus: Add PropertiesChanged signal to Peer object
  dbus: Remove GroupMember object type and use Peer instead

 src/p2p/p2p_group.c                         |   2 +-
 wpa_supplicant/dbus/dbus_new.c              | 228 ++++++++++++----------------
 wpa_supplicant/dbus/dbus_new.h              |  24 ++-
 wpa_supplicant/dbus/dbus_new_handlers_p2p.c |  63 +++++++-
 wpa_supplicant/dbus/dbus_new_handlers_p2p.h |  13 +-
 wpa_supplicant/notify.c                     |  22 +--
 wpa_supplicant/p2p_supplicant.c             |  42 ++++-
 wpa_supplicant/p2p_supplicant.h             |   4 +
 8 files changed, 231 insertions(+), 167 deletions(-)


More information about the Hostap mailing list