[PATCH 2/7] TDLS: bail on STA add failure in tpk_m1 processing

Peer, Ilan ilan.peer
Tue Jun 17 07:26:49 PDT 2014


Hi Jouni,

> 
> I should have noticed that before pushing the commits, but well, didn't.
> Thankfully static analyzers are more alert at this hour, so this got fixed
> quickly.. That's a NULL pointer dereference on peer if the first goto error case
> is hit (unlikely, but possible).
> 

What static analysis tool are u using? We are using sparse and KW and somehow they both missed this.

Thanks in advance,

Ilan.






More information about the Hostap mailing list