[PATCH 4/4] nl80211: fix of sizeof in vendor event handling

Jouni Malinen j
Wed Jan 22 09:19:39 PST 2014

On Wed, Jan 22, 2014 at 03:15:48PM +0100, Johannes Berg wrote:
> On Wed, 2014-01-22 at 16:05 +0200, Ilan Peer wrote:
> >  			struct nl80211_vendor_cmd_info *vinfo;
> > -			if (nla_len(nl) != sizeof(vinfo)) {
> > +			if (nla_len(nl) != sizeof(*vinfo)) {
> Funny, I guess this worked on 64-bit because the struct is 8 bytes
> long ...

Yeah.. I only tested this on 64-bit since there was no vendor extension
support in mac80211_hwsim in the kernel tree. My server setup is running
with 32-bit builds, but it won't catch manual test cases like this now.
I guess we could consider adding a vendor command into mac80211_hwsim to
enable validation of this functionality in general both in
wpa_supplicant and cfg80211.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list