[PATCH] Postpone scan for 500 ms if in the middle of association

Dmitry Shmidt dimitrysh
Sun Nov 24 11:34:22 PST 2013


On Sun, Nov 24, 2013 at 2:09 AM, Jouni Malinen <j at w1.fi> wrote:
> On Tue, Nov 12, 2013 at 12:49:24PM -0800, Dmitry Shmidt wrote:
>> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
>> @@ -2122,7 +2122,7 @@ static void wpa_supplicant_event_disassoc_finish(struct wpa_supplicant *wpa_s,
>>                       fast_reconnect_ssid = wpa_s->current_ssid;
>>  #endif /* CONFIG_NO_SCAN_PROCESSING */
>>               } else if (wpa_s->wpa_state >= WPA_ASSOCIATING)
>> -                     wpa_supplicant_req_scan(wpa_s, 0, 100000);
>> +                     wpa_supplicant_req_scan(wpa_s, 0, 500000);
>>               else
>>                       wpa_dbg(wpa_s, MSG_DEBUG, "Do not request new "
>>                               "immediate scan");
>
> How could this be in the "middle of association"? This is in
> disassociation event handler, so obviously there is not supposed to be
> an ongoing association at the time. Or is the driver doing something
> strange like starting a new association automatically? If so, that
> driver needs to be fixed or if that behavior needs to be supported, a
> net driver capability advertisement is needed to be added to indicate
> such behavior. Just delaying a scan request here by 400 ms does not make
> any sense to me and is just making all other cases take more time at the
> cost of whatever specific design this was trying to work around.

You are right, thanks.

>
> --
> Jouni Malinen                                            PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP at lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap



More information about the Hostap mailing list