[PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Johannes Berg johannes
Thu May 23 13:12:57 PDT 2013


On Wed, 2013-05-22 at 22:15 +0200, Arend van Spriel wrote:

> > I'd assume I had that in my tests. I was using a wireless-testing.git
> > snapshot. Anyway, whether I had that there or not does not matter since
> > there is obviously at least one snapshot of the kernel where this breaks
> > P2P completely at least for hwsim tests. I cannot apply such changes
> > into hostap.git without protection that avoids regressions with any past
> > kernel snapshot in the default configuration. It would be unfortunate if
> > we have managed to push kernel changes in to claim support for this
> > without it actually working. That would mean that there may be need for
> > manual configuration to enable this in wpa_supplicant and/or a new
> > capability bit in the kernel once things start working.
> 
> The drivers are indicating whether P2P Device is supported. Our brcmfmac 
> driver had it set to 3.9 but it was removed as wpa_supplicant had no 
> support. Bit of a chicken-egg story. Also at least a number of issues in 
> cfg80211 and mac80211 has been found and fixed in 3.10-rc1, so wireless 
> drivers can start to consider announcing P2P Device support. A quick 
> grep in v3.9 shows iwlwifi and mac80211_hwsim are the only driver 
> reporting P2P Device support. That should only be true when cfg80211 and 
> mac80211 changes are also applied to 3.9 kernel and those will probably 
> not work because cfg80211 and mac80211 fixes are missing.

Yes, this is a bit unfortunate. We can probably send a patch to 3.9
stable to remove the P2P_DEVICE advertising. However, I'm not all that
worried about hwsim, and iwlmvm unfortunately is looking like we won't
be able to ship firmware that works with the driver in 3.9 given the
recent firmware changes. As such, I think there aren't and won't be any
real drivers that actually advertise P2P_DEVICE.

> Hope we can make an effort to get wpa_supplicant provide P2P Device 
> support for 3.10+ kernels.

The current wireless-testing should have all the required fixes, can
somebody verify that?

johannes




More information about the Hostap mailing list