[PATCH] ap: Don't use a p2p function if support is not present

Jouni Malinen j
Sat Dec 14 21:22:40 PST 2013


On Mon, Dec 09, 2013 at 02:49:13PM +0200, Tomasz Bursztyka wrote:
> Minor built issue, if CONFIG_P2P is set to N, wpas_p2p_get_vht80_center
> cannot be called.

> diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c
> @@ -47,8 +47,9 @@ static void wpas_conf_ap_vht(struct wpa_supplicant *wpa_s,
>  {
> -	u8 center_chan = 0;
>  	u8 channel = conf->channel;
> +#ifdef CONFIG_P2P
> +	u8 center_chan = 0;
>  
>  	if (!conf->secondary_channel)
>  		goto no_vht;
> @@ -63,6 +64,7 @@ static void wpas_conf_ap_vht(struct wpa_supplicant *wpa_s,
>  	return;
>  
>  no_vht:
> +#endif /* CONFIG_P2P */
>  	conf->vht_oper_centr_freq_seg0_idx =
>  		channel + conf->secondary_channel * 2;

Hmm.. Wouldn't this skip VHT configuration completely without
CONFIG_P2P? Maybe making wpas_p2p_get_vht_center() be a less specific to
P2P would be better fix..

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list