[PATCH 6/7] Adding autoscan module named exponential

Jouni Malinen j
Tue Jun 26 09:50:03 PDT 2012


On Tue, Jun 26, 2012 at 11:05:51AM +0300, Tomasz Bursztyka wrote:
> This module will compute the interval on a base exponential.
> Thus, params to this module are following this format: <base>:<limit>

> diff --git a/wpa_supplicant/autoscan_exponential.c b/wpa_supplicant/autoscan_exponential.c
> +	if (data->interval <= 0)
> +		data->interval = data->base;
> +
> +	data->interval = data->interval * data->base;

This initializes data->interval to base^2, not base. I would assume this
was not the goal here. In addition, the first call here that goes beyond
data->limit can return a value larger than the limit. I would assume
that that was also not the purpose since the following call will limit
this to a smaller value.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list