[PATCH] P2P: Fix setting P2P Client Discoverability bit
Mon Jun 18 05:02:06 PDT 2012
Thanks for a P2P Client Discoverability bit updation patch. I have a
question for the patch.
At p2p_add_group_clients() an else caluse was added for the sentence below.
if (dev->flags & (P2P_DEV_GROUP_CLIENT_ONLY | P2P_DEV_PROBE_REQ_ONLY))
But I could not make a test case which uses the else clause.
I have thought the P2P_DEV_GROUP_CLIENT_ONLY bit in the dev->flags is
always enabled. Because the device is in the P2P Group Info Attribute.
What case do you expect about the else clause ?
2012/6/17 Jouni Malinen <j at w1.fi>:
> On Wed, Jun 13, 2012 at 10:18:20PM +0900, Masashi Honma wrote:
>> In the , the P2P Client Discoverability bit is described in "Table 12 Device
>> Capability Bitmap definition". The table says "Within a P2P Group Info
>> attribute and a (Re)association request frame the P2P Client Discoverability
>> field shall be set to 1 when the P2P Device supports P2P Client Discoverability,
>> and is set to 0 otherwise. This field shall be reserved and set to 0 in all
>> other frames or uses.". So I made this patch to make it suitable for the spec.
> Thanks! Applied. Though, this triggers a bug where device
> discoverability cannot be used in some cases due to how this dev_capab
> bit is learned. I fixed that with commit
> Jouni Malinen ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?PGP id EFC895FA
> HostAP mailing list
> HostAP at lists.shmoo.com
More information about the Hostap