[PATCH] driver_nl80211: disable 11b rates on interface change

Arik Nemtsov arik
Sun Dec 23 13:59:29 PST 2012


On Sun, Dec 23, 2012 at 12:59 PM, Jouni Malinen <j at w1.fi> wrote:
> On Sun, Dec 09, 2012 at 10:30:26AM +0200, Arik Nemtsov wrote:
>> 11b rates were disabled during interface addition, but
>> not on interface mode change.
>>
>> Disable/Enable 11b rates in wpa_driver_nl80211_set_mode(),
>> according to the interface type (p2p or not).
>
>> +     nl80211_disable_11b_rates(drv, drv->ifindex, is_p2p_interface(nlmode));
>
> Is this really needed? There is a call to nl80211_disable_11b_rates()
> just above this in the same wpa_driver_nl80211_set_mode() function (from
> commits edb9bfba8914932aa44657c41fb99dc984e1f8d2 and
> 1d0c6fb1ebe1feaec76bfb7f00c05349e18973aa).

You're right of course. This was ported from an old version and we
didn't notice the change.

Arik



More information about the Hostap mailing list