[RFC 06/13] TDLS: support sending a teardown frame from usermode

Arik Nemtsov arik
Thu Sep 15 23:08:34 PDT 2011


On Thu, Sep 15, 2011 at 14:15, Johannes Berg <johannes at sipsolutions.net> wrote:
> On Thu, 2011-09-15 at 13:22 +0300, Arik Nemtsov wrote:

>> +static int wpa_tdls_do_teardown(struct wpa_sm *sm, struct wpa_tdls_peer *peer,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? u16 reason_code)
>> +{
>> + ? ? /* try asking the driver to teardown the link */
>> + ? ? int ret = wpa_sm_tdls_oper(sm, TDLS_TEARDOWN, peer->addr);
>> +
>> + ? ? /* it it doesn't work - send an explicit teardown message */
>> + ? ? if (ret) {
>
> I think that should be a feature flag rather than always trying &
> falling back.
>
> johannes
>

That's a good idea. I'll add separate wiphy capability flags for
external discovery/setup/teardown. This will have to come all the way
from kernel, to accommodate full-mac nl80211 based drivers that want
this internally.

I'm queuing this up for v2.

Arik



More information about the Hostap mailing list