[PATCH 2/6] nl80211: Convert some wpa_printf to wpa_msg methods.

Ben Greear greearb
Thu Oct 20 06:34:30 PDT 2011


On 10/20/2011 06:29 AM, Johannes Berg wrote:
> On Thu, 2011-10-20 at 06:24 -0700, Ben Greear wrote:
>> On 10/20/2011 04:20 AM, Johannes Berg wrote:
>>> On Wed, 2011-10-19 at 12:20 -0700, greearb at candelatech.com wrote:
>>>> From: Ben Greear<greearb at candelatech.com>
>>>>
>>>> This helps debugging when you have multiple interfaces
>>>> handled by a single process.
>>>
>>> This means they will show up on the control interface. Generally, I
>>> think no driver messages should show up on the control interface as that
>>> breaks the abstraction.
>>
>> What are the ctrl-interface messages for?  If it's to show debug info and such to the
>> user, then how can it hurt to have driver specific messages?
>
> Well I guess there are multiple things, but there are definitely
> messages there that applications would parse. And given how easy it
> would then be to start parsing a driver-specific message ...

Hopefully the DEBUG messages don't show up by default anyway, and if someone
was crazy enough to try to parse them, then hopefully they are smart enough
to be clever with their parsing and able to deal with any issues.

 From what I can tell, wext is basically dead anyway, so the netlink driver
is the only thing really worth using these days...

>> But, I can change everything to wpa_lmsg or somthing that just logs
>> to a file if you prefer...
>
> That'd make more sense to me.

Jouni:  Please let me know which you prefer.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



More information about the Hostap mailing list