[PATCH] Reset the ssid in wps before being replaced with the one in credential.

張晏榕 jungwalk
Fri Dec 9 05:31:56 PST 2011

Oops, typo.

What I wanted to say is "in case the length of ssid in wps->ssid is longer
than the one in credential".
Then, does this make more sense?
If it is, I will resend the patch.

2011/12/9 Johannes Berg <johannes at sipsolutions.net>

> On Fri, 2011-12-09 at 13:10 +0800, jungwalk at gmail.com wrote:
> > From: Spencer Chang <jungwalk at gmail.com>
> >
> > It is better to reset the ssid in WPS first before it is replaced with
> the one in
> > credential in case the length of ssid in credential is longer than
> wps->ssid.
> > +     os_memset(hapd->wps->ssid, 0, HOSTAPD_MAX_SSID_LEN);
> >       os_memcpy(hapd->wps->ssid, cred->ssid, cred->ssid_len);
> >       hapd->wps->ssid_len = cred->ssid_len;
> That seems completely useless, in particular when it's longer since then
> it will partially overwrite it anyway. They are binary data, not
> strings, after all.
> johannes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.shmoo.com/pipermail/hostap/attachments/20111209/d8a8499f/attachment.htm 

More information about the Hostap mailing list