[PATCH] Make proactive key caching working again

[Jouni Malinen]

On Sun, Jul 06, 2008 at 06:43:18PM +0300, Jouni Malinen wrote:
> On Wed, Jul 02, 2008 at 03:41:57PM +0200, Michael Bernhard wrote:
> > The second reason no proactive key was generated is, that each time 'wpa_sm_set_config'
> > was called the network context in all pmkasa cache entries was cleared.
> > 
> > To avoid this problem, a check is made if the new network context differs from the saved
> > network context (in sm->network_ctx) before copying the data.

> This is something that I will need to take a closer look at in order to
> figure out how exactly this was supposed to work and whether something
> was broken at some point or whether the original design did not work
> properly. I did not yet apply this part since I'm not sure whether it
> could cause some problems in practice.

It looks like the original design was supposed to update the network
parameters, but not call pmksa_cache_notify_reconfig() if the network
context remained same. I did this by moving the validation to the end of
the function, but other than that, the change was very similar to yours.

I added support of opportunistic key caching into hostapd and when
testing the modified wpa_supplicant against this, everything seemed to
be working fine. Please let me know if the current git version does not
fix the issues you have seen.

-- 
Jouni Malinen                                            PGP id EFC895FA